-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check that the range param is not undefined #13540
fix: check that the range param is not undefined #13540
Conversation
|
Hi @JesuHrz, thanks for the PR! Could you please fill out the bug report template? I believe this might be a known bug in |
Hi @mdjermanovic, sorry I accidentally closed the PR, but I was able to open it again. |
Thanks! Could you please also paste the source code ( This will helps us with reproducing the bug and finding the cause. |
Of course, not problem @mdjermanovic, it already is updated |
Hm, I still can't see it. Sorry if it wasn't clear - we need the content of the file that was linted ( If you can't share the whole file (which would be ideal), a small part would do the work if the bug is reproducible on it. It looks like this is crashing on a template literal in your code, and I'd guess it's a code like |
I just updated the code, it's already complete. @mdjermanovic I think the mistake comes from the first line |
Thanks for all details! I can reproduce this bug. The issue is with dynamic imports; when I comment out all three, then it doesn't crash. A minimal code to reproduce the error: import(/* webpackChunkName: "common" */ `../routes/${module}`) This is a bug in We shouldn't change the This will be fixed in the next version of |
Ohh great!! |
I'm closing this since it isn't a bug in the It's a known bug in The bug should be fixed in the next version, under the new package name Nevertheless, thanks for the PR! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR resolved the next issue:
When I add this option
"parser": "babel-eslint"
in my.eslintrc
file but I also have this rules"indent": ["error", 2]
or some other implementation of this rule and I want to runeslint .
oreslint . --fix
.The terminal gave us this error:
This error only happens when I have these options in my
.eslintrc
file.When adding this validation in this
setDesiredOffsets
function and I run some of these optionseslint .
oreslint . --fix
, the eslint output is completed without any problemNote:
if any of you have some feedback or a better solution, please let me know.
Is there anything you'd like reviewers to focus on?
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
I'm using this parser
babel-eslint
with the versionv10.1.0
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
This error happens when I have this configuration and run
eslint .
oreslint . --fix
.Code
What did you expect to happen?
I expected the eslint output was completed with my code indented
What actually happened? Please include the actual, raw output from ESLint.